[Bug 478767] Review Request: spring - Realtime strategy game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478767


Ian Weller <ianweller at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(ianweller at gmail.c |
                   |om)                         |




--- Comment #8 from Ian Weller <ianweller at gmail.com>  2009-01-17 20:42:38 EDT ---
(In reply to comment #7)
> > The Description doesn't seem very descriptive. Can you be more specific?
> 
> OK, I've tried to add a few lines from Wikipedia, and I've added a
> README.Fedora file.
> 
Oops, I meant to say the Summary isn't very descriptive. But thanks for the
other addition, too!

> > - Since spring-engine is a subpackage of spring with the same versioning,
> > the requires between these packages need to be version/release specific.
> 
> Hmm, I'm not sure, because the "spring" package here is just a meta-package to
> pull all needed package to play the game. The meta-package in itself does not
> care which version of the spring-engine is installed. It's not like -devel
> subpackages.
> It's not a problem to add the version either, so if you really feel it should
> be a versioned dependency, I'll add it.
> 
This isn't a packaging requirement (I thought it was, silly me), but keep in
mind that if this isn't followed, those users who update the spring package
alone will not see an update to spring-engine. Of course, since this is a
metapackage, the other deps wouldn't seen an update either unless you hardcoded
other values.

Full review in a bit.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.