[Bug 473583] Review Request: WordNet - A lexical database for the english language

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=473583





--- Comment #9 from steve <steve at lonetwin.net>  2009-01-17 22:00:56 EDT ---
Debarshi,

Thanks for the through review and all your comments !

(In reply to comment #7)
> The manual pages append "WN" to the section numbers. There is a Debian patch to
> fix this. It will be good to have in our package too.

Fixed. I also noticed that although the Debian patch fixed the names of the man
pages, it didn't fix the references with the pages itself. I've done those too.

> > I could still rename the package if you still think it is a good thing.
> 
> Finally it is going to be yours and your sponsor's call, but I think "wordnet"
> is better.

Fixed.

(In reply to comment #8)
> + The package fails to build in a chroot:
> http://koji.fedoraproject.org/koji/taskinfo?taskID=1062215 To fix this add
> 'BuildRequires: libXft-devel'.

Fixed.

> + Header and lib*.so should not be a part of the main package. Instead they
> should be put in a -devel sub-pacakge. See:
> https://fedoraproject.org/wiki/Packaging/Guidelines#Devel_Packages

Fixed.

The new srpm and spec file are at:
http://lonetwin.net/wordnet.spec
http://lonetwin.net/wordnet-3.0-3.fc10.src.rpm

- steve

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.