[Bug 478769] Review Request: spring-installer - Installer for the Spring game's maps and mods

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478769





--- Comment #6 from Aurelien Bompard <gauret at free.fr>  2009-01-19 14:41:26 EDT ---
> * Not sure about grabbing the data from what appears to be part of their
> filesystem that is laid out to fit neatly into the ubuntu repository. Might be
> a bit too dynamic... The Git repository sounds like a much better idea.

Actually, the tarballs are better to check that I'm not introducing malware in
Fedora. With a Git clone, it would be a little harder to check, and the SCM has
already changed in the past.
I have contacted the author about this, so hopefully he's aware of this issue.

> * I think offering an installer for a TA mod "CA" may have licencing issues. 
> TA is copyright of what used to be infogrames, which i know think is Atari. 
> The content that this installer obtains is probably copyright protected, as I
> undesrtand that Complete Annihilation uses TA game data. 

The package does not contain the copyrighted files, you still have to download
them by hand. The CA installer does not download them.

> * Is specifying the content of the sub-package in the main package description
> normal? I have not seen this before, and it strikes me as a touch confusing.

Oops, no, that's a cut-n-paste mistake. Good catch !

> * Using chrpath to remove hardcoding of path information is considered a last
> resort option [1].  Consider patching the build system to remove invocations 
> to chrpath. 

It looks like it very very hard to remove rpath with ocaml. I've search the web
but the only available option seems to use chrpath. If you find a cleaner way,
I'm interested of course.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.