[Bug 480567] Review Request: dnssec-conf - DNSSEC and DLV configuration and priming tool
bugzilla at redhat.com
bugzilla at redhat.com
Mon Jan 19 19:54:52 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480567
Jochen Schmitt <jochen at herr-schmitt.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |jochen at herr-schmitt.de
AssignedTo|nobody at fedoraproject.org |jochen at herr-schmitt.de
Flag| |fedora-review?
--- Comment #1 from Jochen Schmitt <jochen at herr-schmitt.de> 2009-01-19 14:54:51 EDT ---
God:
+ Basename of the SPEC files matches with package name
+ Name of the package fits naming guidelines
+ Package contains most recent release
+ Package contains valid License tag
+ License tag contains GPLv2+ as a valid OSS license
+ License review on source files state, that GPLv2 may be
+ Package contains a verbatin copy of the license text
+ Package has no subpackages
+ Local buidl works fine
+ Package contains %clean stanza
+ Buildroot will be deleted on the beginning of %clean and %install
+ Local install works fine
+ Local uninstall works fine
+ Start of dnssec-conf without argument works witoht crash
+ Build on koji works fine
+ Rpmlint has no complaints about the source package
+ Rpmlint has no complaints about the binary package
+ Files has proper file permissions
+ All packaged files belong to the package
+ Package contains no files belong to other packages
+ %doc subpackage has a small amont, so we need no separate doc subpackage
+ Package contains proper %changelog
Bad.
- source tag not fully quallified
- Package use $RPM_BUILD_ROOT and %{buildroot}
- License review on source files state, that GPLv2 may be
right value for the license tag
TODO:
- Please notify upstream, that eatch source file should have
a proper copyright notice
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list