[Bug 464781] Review Request: flexdock - Java docking UI element. First package.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=464781





--- Comment #23 from Dominik 'Rathann' Mierzejewski <rpm at greysector.net>  2009-01-19 17:55:25 EDT ---
Some comments before full review:

Why do you have:
BuildArch: i386
BuildArch: x86-64
BuildArch: ppc
in the spec? BuildArch: can only be specified once, so merge these three.
Otherwise it fails with:

$ rpmbuild -bb flexdock.spec
error: No compatible architectures found for build

x86-64 is not a valid arch designation, by the way. You should use x86_64.
I think you should use ExcludeArch: ppc64 to disable the unsupported arch
instead and open a bug for that (blocking FE-ExcludeArch-ppc64 tracker bug).

Fails to build in mock on rawhide/i386:
[...]
++ build-classpath jgoodies-looks skinlf
/usr/bin/build-classpath: error: Could not find jgoodies-looks Java extension
for this JVM
/usr/bin/build-classpath: error: Could not find skinlf Java extension for this
JVM
/usr/bin/build-classpath: error: Some specified jars were not found
[...]

You seem to have forgotten to add these as BuildRequires as well.

Once the above are fixed, it builds in mock, but rpmlint output is not clean:
$ rpmlint /var/lib/mock//fedora-rawhide-i386/result
flexdock-debuginfo.i386: E: empty-debuginfo-package
flexdock.src:157: E: files-attr-not-set
flexdock.src:158: E: files-attr-not-set
flexdock.src:159: E: files-attr-not-set
3 packages and 0 specfiles checked; 4 errors, 0 warnings.

You need to fix that.

According to Java Packaging Guidelines, you're installing the files in the
wrong location. Please fix that.

Also, the specfile has lots of trailing whitespace and inconsistent usage of
spaces and tabs for indentation. Please fix that, too.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.