[Bug 464781] Review Request: flexdock - Java docking UI element. First package.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=464781





--- Comment #28 from Dominik 'Rathann' Mierzejewski <rpm at greysector.net>  2009-01-20 16:31:36 EDT ---
(In reply to comment #27)
> (In reply to comment #26)
> [...]
> > strip --strip-unneeded $SOFILE
> > 
> > Calling strip from the specfile is not allowed. rpm post-build scripts do that
> > while building the debuginfo package.
> 
> Although in this case they seem to fail. If I remove that strip call, I get:
> $ rpmlint /var/lib/mock//fedora-rawhide-i386/result
> flexdock-debuginfo.i386: E: empty-debuginfo-package
> flexdock.i386: W: unstripped-binary-or-object
> /usr/lib/flexdock/libRubberBand-0.so

Actually it's simple. Just don't chmod the .so to 644. It has to be executable
for rpmbuild debuginfo scripts to find it. rpmlint is silent afterwards.

Some more nitpicks:

You don't need
mkdir -p %{buildroot}/usr/share

There's still trailing whitespace in the following lines:
Name:           flexdock

# This patch is fedora specific -- System.loadLibrary fix to help locate JNI
components

#Licence is MIT on their website, Apache in their LICENSE.txt

patch3:         flexdock-skinlfTitlebarui-path.patch
patch4:         flexdock-skinlfPainter-path.patch

BuildRequires:  java-1.6.0-openjdk-devel

Requires:       libX11 >= 1.1.4

                        JDK_DIR=`echo %{_jdkdir} | sed 's!/$!!'`.`uname -m`

                echo "Relying on spec file buildpath: $JDK_DIR " >> tmpLog
                echo "sdk.home=$JDK_DIR"  > workingcopy.properties

# https://skinlf.dev.java.net/

ant  -Dbuild.sysclasspath=first build.with.native jar

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.