[Bug 459535] Review Request: backup-manager - A command line backup tool for GNU/Linux

bugzilla at redhat.com bugzilla at redhat.com
Wed Jan 21 11:48:21 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459535


Christoph Wickert <fedora at christoph-wickert.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #38 from Christoph Wickert <fedora at christoph-wickert.de>  2009-01-21 06:48:13 EDT ---
(In reply to comment #36)
> @Christoph > Your review is finish ? The review is approve ? Because this
> review block my sponsorships and the pidgin-privacy-please integration...

Why that? I thought Aurelien already said he will sponsor you.

I'm not really happy with the hardcoded paths bin /backup manager, but on the
other hand I don't want to write a ./configure. This should be done upstream.

I see backup-manager-0.7.7-7.fc10 fixes all issues from comment #23, but
instead of
  %{name}-%{version}-configtpl.patch
you should use
  %{name}-0.7.7-configtpl.patch
Otherwise you will have to delete and re-add the file in cvs on every update.

Nevertheless this is your decision and you can fix it after import, so I will
APPROVE the package now.


(In reply to comment #37)
> The spec file contains 'Requires' lines which are not really needed - see:
> http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

This list is for _BuildRequries_ in the build system but not for _Requires_ of
the package itself.
Also note that your third test from comment #28 is not supposed to work.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list