[Bug 479832] Review Request: mmpong - a massively multiplayer pong game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479832





--- Comment #7 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-01-21 13:03:58 EDT ---
Well, rpmlint <rpmname> should work and checking your rpms
by rpmlint is always recommended.


For 0.9-2
- BuildRequires: gcc is redundant:
  https://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

- I think people don't expect that "$ yum install mmpong" will
  install development packages (i.e. -devel).
  Rather I think that mmpong-client-caca should be renamed to
  mmpong.

- By the way "Requires: %{name}-libs=%{version}-%{release}"
  will seek for a rpm package with the name 
  "%{name}-libs=%{version}-%{release}" (not %{name}-libs), so
  anyway this needs fixing (I guess if you try to install
  this rpm you will see such errors.)

- The Group "Libraries" is not common. You can see the Group
  tag which Fedora regards as valid by:
  $ rpmlint -I non-standard-group

- Summary should begin with a capital letter.

- Usually dependencies within packages rebuilt from a srpm
  must be exact EVR (Epoch-Version-Release) specific, not
  with inequality

- For -client-gl subpackage, "Requires: libgl" is not needed.
  Such libraries based dependency is automatically detected by
  rpmbuild itself and rpmbuild correctly adds such dependency
  to rebuilt binary rpms.

- Also, would you explain why the dependency for libcaca(-devel) is
  EVR specific? (If there is some reason, please write
  it as comments in the spec file)

- %cmake macro already sets -DCMAKE_INSTALL_PREFIX:PATH, 
  -DCMAKE_INSTALL_LIBDIR:PATH (and -DLIB_SUFFIX=64 for 64 bits
  architecture), and CFLAGS and so on.
  Would you check if "-DCMAKE_INSTALL_PREFIX=%{_prefix} ...."
  in your spec file really needed with using %cmake macro?

  By the way what %cmake macro does can be shown by
  $ rpm --eval %cmake . Also please check
  https://fedoraproject.org/wiki/Packaging/cmake

- On Fedora %run_ldconfig macro is not defined
  (Is this really working on your Fedora system?)

  (Also, as currently mmpong package is just empty, no scriptlets
   is needed... however also please see my suggestion about renaming
   -client-caca subpackage for this issue)

- For -libs subpackage, /sbin/ldconfig must be called on %post{,un}
  scriptlets. Add
---------------------------------------------------------
%post libs -p /sbin/ldconfig
---------------------------------------------------------
  for example.
  https://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries

- Any packages containing pkgconfig .pc files must have
  "Requires: pkgconfig".
  https://fedoraproject.org/wiki/Packaging/Guidelines#Pkgconfig_Files

- By the way even on x86_64, mmpong.pc contains:
---------------------------------------------------------
     3  libdir=${exec_prefix}/lib
---------------------------------------------------------
  This is not correct because on 64 bits architecture libdir should
  point to /usr/lib64, not /usr/lib.

- The directory %{_includedir}/mmpong must be owned by -devel
  subpackage:
 
https://fedoraproject.org/wiki/Packaging/Guidelines#File_and_Directory_Ownership
 
https://fedoraproject.org/wiki/Packaging/UnownedDirectories#Wildcarding_Files_inside_a_Created_Directory

- Directories for installing man files are not right.
  For example, man files with suffix 6 should be installed under
  %{_mandir}/man6 (then rpmbuild automatically gzips this file)

- Again desktop files to be installed must be treated by
  "desktop-file-{install,validate}": see
 
https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage
  Currently mmpong-gl.desktop is a invalid desktop file
  and need fixing by desktop-file-install.

- -client-gl package must not own %_datadir/icons/hicolor
   directory and so on (also here please check
  
https://fedoraproject.org/wiki/Packaging/Guidelines#File_and_Directory_Ownership
   and check what directories are owned by hicolor-icon-theme)

- Usually daemon executables are installed under %{_sbindir} (i.e.
  /usr/sbin ) and some initscript is provided.
  * Would you check if mmpongd should be under %_bindir or
    %_sbindir ? (I don't know well about mmpongd, however I guess
    this should be under %_sbindir)
  * Also would you consider to supply sysv initscripts for mmpongd?
    https://fedoraproject.org/wiki/Packaging/SysVInitScript

- As -client-gl installs some icons under %_datadir/icons/hicolor,
  please check
  https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GTK.2B_icon_cache

- Please create %changelog
  https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.