[Bug 481141] Review Request: pycryptsetup - Python bindings for cryptsetup tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481141





--- Comment #4 from Matej Cepl <mcepl at redhat.com>  2009-01-23 08:33:47 EDT ---
Still not silent rpmlint:

> python-cryptsetup.src: W: strange-permission python-cryptsetup.spec 0600
> A file that you listed to include in your package has strange permissions.
> Usually, a file should have 0644 permissions.

That's from your playing with git ;-)

and on the binary package:
> python-cryptsetup.x86_64: W: spurious-executable-perm /usr/share/doc/python- cryptsetup-0.0.1/selftest.py
> python-cryptsetup.x86_64: W: incoherent-version-in-changelog 0.0.1 ['0.0.1-1.fc10', '0.0.1-1']
> python-cryptsetup.x86_64: W: unstripped-binary-or-object /usr/lib64/python2.5/site-packages/cryptsetup.so
> python-cryptsetup.x86_64: W: doc-file-dependency /usr/share/doc/python-cryptsetup-0.0.1/selftest.py /usr/bin/python

Please, get rid of these (or at least most of them -- the last probably goes
away if the examples are not executable). No idea, about unscript binary
object.

> #Requires: cryptsetup-luks

It is considered bad habit to comment out in spec files -- CVS is not an ideal
VCS, but we have previous versions recorded.

> Requires: python

Don't you care about version? Will python 1.5 work? (OK, maybe not that, but
people may want to rebuild this on RHEL for example).

What happened to examples/ ?

Still no URL in Source. Stuff you have in URL: field should be in Source:
However, MD5 is OK
d6b3486e096097c52e939b40c33aa130

So, yes, we need one more round to get this together.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.