[Bug 476973] Review Request: eclipse-rpmstubby - Rpm specfile generator for Eclipse features

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476973


Orcan 'oget' Ogetbil <oget.fedora at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |oget.fedora at gmail.com
         AssignedTo|nobody at fedoraproject.org    |oget.fedora at gmail.com
               Flag|                            |fedora-review+




--- Comment #1 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com>  2009-01-23 14:37:18 EDT ---
I made the review. There are a few minor things to go over:

* Two Changelogs need packaged:
   ./org.eclipse.linuxtools.rpmstubby-feature/ChangeLog
   ./org.eclipse.linuxtools.rpmstubby/ChangeLog

* I think URL needs to be: 
   http://www.eclipse.org/linuxtools/projectPages/rpmstubby/

? Could you provide a download location at the project homepage so we don't
need to use this fetch script?

* Macros should be used consistently. You use %{buildroot} and $RPM_BUILD_ROOT
mixed. This needs corrected. You should also use %{__install} for consistency.

* Summary looks awkward to me, maybe it should be shortened to:
   Rpm specfile generator for Eclipse


These are all easy to do. I'm approving the package now.


----------------------------------------------------
This package (eclipse-rpmstubby) is APPROVED by oget
----------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.