[Bug 479595] Review Request: raddump - RADIUS packets interpreter

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479595


Adel Gadllah <adel.gadllah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |adel.gadllah at gmail.com
         AssignedTo|nobody at fedoraproject.org    |adel.gadllah at gmail.com
               Flag|                            |fedora-review+




--- Comment #1 from Adel Gadllah <adel.gadllah at gmail.com>  2009-01-24 14:49:32 EDT ---
REVIEW:

[+] = OK
[-] = NOT OK
[1] = SEE COMMENTS
[?] = WTF?

===========================

[+] source files match upstream:
  sha1: 13b75ec8ad1f4fcbed7ebe7373718ec254429e72
[+] package meets naming and versioning guidelines.
[+] specfile is properly named, is cleanly written and uses macros
consistently.
[+] dist tag is present.
[+]  build root is correct.
[+] license field matches the actual license.
[+] license is open source-compatible.
  GPLv2+
[+] license text included in package.
[+] latest version is being packaged.
[+] BuildRequires are proper.
[+] compiler flags are appropriate.
[+] %clean is present.
[+] package builds in koji:
  http://koji.fedoraproject.org/koji/taskinfo?taskID=1079868
[+] package installs properly.
[+] debuginfo package looks complete.
[+] rpmlint is silent.
[+] final provides and requires are sane
[+] no shared libraries are added to the regular linker search paths.
[+] owns the directories it creates.
[+] doesn't own any directories it shouldn't.
[+] no duplicates in %files.
[+] file permissions are appropriate.
[+] no scriptlets present.
[+] code, not content.
[+] documentation is small, so no -docs subpackage is necessary.
[+] %docs are not necessary for the proper functioning of the package.
[+] no headers.
[+] no pkgconfig files.
[+] no libtool .la droppings.

===========================

COMMENTS:

None, package looks good, no issues found.

=> APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.