[Bug 480373] Review Request: cilk - Language for multithreaded parallel programming.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480373





--- Comment #4 from Ian Weller <ianweller at gmail.com>  2009-01-25 00:43:45 EDT ---
- %dir isn't necessary in %files. you can just list the directory and it will
  automatically add all the files under it too (so get rid of the two lines
  under the %dir lines while you're at it)

- rpmlint is very loud:
cilk.src:23: W: configure-without-libdir-spec
cilk.src:51: W: macro-in-%changelog optflags
cilk.src: W: summary-ended-with-dot Language for multithreaded parallel
programming.
cilk.i386: W: devel-file-in-non-devel-package /usr/lib/libcilk.a
cilk.i386: W: devel-file-in-non-devel-package /usr/lib/libcilk.g.p.a
cilk.i386: W: devel-file-in-non-devel-package /usr/lib/cilk/libcilkrt0gp.a
cilk.i386: W: devel-file-in-non-devel-package /usr/lib/libcilk.p.so
cilk.i386: W: devel-file-in-non-devel-package /usr/include/cilk/gcc-builtin.h
cilk.i386: W: devel-file-in-non-devel-package /usr/lib/cilk/libcilkrt0g.a
cilk.i386: W: devel-file-in-non-devel-package /usr/lib/libcilk.g.a
cilk.i386: W: devel-file-in-non-devel-package /usr/lib/libcilk.so
cilk.i386: W: devel-file-in-non-devel-package /usr/include/cilk/cilk-sysdep.h
cilk.i386: W: devel-file-in-non-devel-package /usr/lib/libcilk.g.so
cilk.i386: W: devel-file-in-non-devel-package /usr/include/cilk/cilk-conf.h
cilk.i386: W: devel-file-in-non-devel-package /usr/include/cilk/cilk-cilk2c.h
cilk.i386: W: devel-file-in-non-devel-package /usr/include/cilk/cilk-lib.h
cilk.i386: W: devel-file-in-non-devel-package /usr/lib/cilk/libcilkrt0.a
cilk.i386: W: devel-file-in-non-devel-package /usr/lib/cilk/libcilkrt0p.a
cilk.i386: W: devel-file-in-non-devel-package /usr/lib/libcilk.g.p.so
cilk.i386: W: devel-file-in-non-devel-package
/usr/include/cilk/cilk-cilk2c-pre.h
cilk.i386: W: devel-file-in-non-devel-package /usr/lib/libcilk.p.a
cilk.i386: W: devel-file-in-non-devel-package /usr/include/cilk/cilk.h
cilk.i386: W: summary-ended-with-dot Language for multithreaded parallel
programming.
cilk.i386: W: shared-lib-calls-exit /usr/lib/libcilk.g.so.0.0.0 exit at GLIBC_2.0
cilk.i386: W: shared-lib-calls-exit /usr/lib/libcilk.p.so.0.0.0 exit at GLIBC_2.0
cilk.i386: W: shared-lib-calls-exit /usr/lib/libcilk.g.p.so.0.0.0
exit at GLIBC_2.0
cilk.i386: W: shared-lib-calls-exit /usr/lib/libcilk.so.0.0.0 exit at GLIBC_2.0
3 packages and 0 specfiles checked; 0 errors, 27 warnings.

- why did you replace %configure?

- you can use
    %configure CFLAGS="%(echo "%optflags" | sed -e 's/-pipe//' | sed -e
's/--param=ssp-buffer-size=4//')"
  instead of getting rid of the compiler flags altogether. This keeps
cilkclocal
  happy and keeps most of the compiler flags.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.