[Bug 472229] Review Request: PyQwt - Python bindings for Qwt

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472229


Tadej Janež <tadej.janez at tadej.hicsalta.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(tadej.janez at tadej |
                   |.hicsalta.si)               |




--- Comment #8 from Tadej Janež <tadej.janez at tadej.hicsalta.si>  2009-01-25 12:35:22 EDT ---
Thank you for taking time to review my fixed package!
And I apologize again for responding so late.

(In reply to comment #5)
> Well, for 5.1.0-2:
> 
> * Header files dependency:
>   - Well, for example the installed QwtModule.sip contains:
> ----------------------------------------------------------------
>     63  #include <sipQwtQwtArrayDouble.h>
>     64  #include <sipQwtQwtArrayInt.h>
>     65  #include <sipQwtQwtArrayQwtDoubleInterval.h>
>     66  #include <sipQwtQwtArrayQwtDoublePoint.h>
> -----------------------------------------------------------------
>     However these header files are not installed. Would
>     you check if these are ignored?

I traced what is happening to these files.
configure/configure.py in PyQwt-5.1.0.tar.gz contains:
---------------------------------------------------------------------
745  # FIXME: sip-4.7 does not generate those include files anymore
746      for name in [os.path.join(tmp_dir, name) for name in [
747          'sipQwtQwtArrayDouble.h',
748          'sipQwtQwtArrayInt.h',
749          'sipQwtQwtArrayQwtDoubleInterval.h',
750          'sipQwtQwtArrayQwtDoublePoint.h',
751          ]]:
752          if not os.path.exists(name):
753              open(name, 'w')
---------------------------------------------------------------------

So these files get created after running 'python configure.py ...', however,
they remain empty.
Furthermore 'make install' doesn't install them anywhere, which would indicate
that they are obsolete.

I think this is an issue that should be handled upstream.
I submitted a bug in sourceforge.net bug tracker:
https://sourceforge.net/tracker2/?func=detail&aid=2534030&group_id=82987&atid=567933

UPDATE: The author of the package responded that this was a rudimentary hack
to maintain backwards compatibility with older SIP versions and he will remove
it in future versions of the package.

> * About grace.py
>   - Well, I checked this file again and actually this file is 
>     executable, so it is more correct that this script should simply
>     have 0755 permission (while for qplt.py it seems that
>     this script cannot be executed directly).

OK, made grace.py executable again.

> Then:
> -------------------------------------------------------------
> NOTE: Before being sponsored:
> 
> This package will be accepted with another few work. 
> But before I accept this package, someone (I am a candidate) 
> must sponsor you.

I would be very glad if you could sponsor me.

> When you have submitted a new review request or have pre-reviewed other 
> person's review request, please write the bug number on this bug report 
> so that I can check your comments or review request.

Ok, I did a pre-review of python-webunit package, which is tracked at bug
481272.
Please check its quality and instruct me on my next steps.

I also uploaded updated spec file and source package at
http://tadej.hicsalta.si/packages/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.