[Bug 480886] Review Request: tse3 - MIDI Sequencer Engine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480886





--- Comment #2 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com>  2009-01-25 15:12:41 EDT ---
Thank you.

(In reply to comment #1)
> 
> * About Patch2:
>   - Well, google shows that awe_voice.h was removed from
>     kernel headers at 2.6.21 or so (i.e. around Fedora 7)
>     I don't think it is preferrable to re-introduce macros 
>     which was defined in the header file which is no longer 
>     supported. I guess kernel supports AWE32 in other way
>     or kernel does not support AWE32 completely any more.
> 
>     Are macros related to awe_voice.h really needed even
>     now? 
>     (removing all awe32 related parts like attached does not help ?
>      I just tried to remove all awe_voice.h related parts
>      and did not any functionality check as I don't know
>      how to use this software...)
> 

Thanks for the patch. It seems like you are right. But now I am thinking of
dropping the OSS support from tse3 altogether. I see other
applications/libraries in Fedora built with --without-oss flag. 
- It will save us some dependencies, 
- I am not sure how functional the library will be after this patch, and 
- OSS is deprecated, so we won't loose much.

Does that sound OK?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.