[Bug 478447] Review Request: qtgpsc - A client for the gpsd GPS server

bugzilla at redhat.com bugzilla at redhat.com
Wed Jan 28 17:15:16 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478447





--- Comment #1 from Lucian Langa <cooly at gnome.eu.org>  2009-01-28 12:15:15 EDT ---
OK  source files match upstream:
        3e7bf8b2bd2e21c5082a52a37e381046  qtgpsc-0.2.3.tar.gz
OK  package meets naming and versioning guidelines.
OK  specfile is properly named, is cleanly written and uses macros
consistently.
OK  summary a short and concise description.
OK  description is OK.
OK  dist tag is present.
OK  build root is sane.
NOT OK  license field matches the actual license.
OK  license is open source-compatible.
OK  license text included in package.
OK  BuildRequires are proper.
OK  compiler flags are appropriate.
OK  %clean is present.
OK  package builds in mock (rawhide, x86_64).
OK  package installs properly.
OK  debuginfo package looks complete.
OK  rpmlint is silent.
  final provides and requires are sane:
        qtgpsc = 0.2.3-1.fc11
        qtgpsc(x86-64) = 0.2.3-1.fc11
  =
        libX11.so.6()(64bit)
        libXext.so.6()(64bit)
        libc.so.6()(64bit)
        libgcc_s.so.1()(64bit)
        libgps.so.17()(64bit)
        libm.so.6()(64bit)
        libqt-mt.so.3()(64bit)
        libstdc++.so.6()(64bit)
OK  %check is not present; no test suite upstream.
N/A no shared libraries are added to the regular linker search paths.
OK  owns the directories it creates.
OK  doesn't own any directories it shouldn't.
OK  no duplicates in %files.
OK  file permissions are appropriate.
OK  code, not content.
OK  documentation is small, so no -doc subpackage is necessary.
OK  %docs are not necessary for the proper functioning of the package.
OK  no headers.
OK  no pkgconfig files.
OK  no static libraries.
OK  no libtool .la files.
OK  gui application; desktop file installed properly

Source0 is mistyped

desktop-file-validate qtgpsc.desktop
qtgpsc.desktop: warning: value "Application;Utility;" for key "Categories" in
group "Desktop Entry" contains a deprecated value "Application"

License should be BSD not MIT.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list