[Bug 483108] Review Request: chordii - Print songbooks (lyrics + chords)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483108





--- Comment #1 from manuel wolfshant <wolfy at nobugconsulting.ro>  2009-01-29 18:16:00 EDT ---
I suggest to remove the first paragraph of the description. The description tag
cannot refer to anything but the chordii package, hence "This is a description
of a utility called chordii." is redundant. 
The starting phrase of the second paragraph should be modified accordingly, for
instance "The purpose of chordii is to provide guitar players with [...]"

Please examine if the build process can take advantage of compiling in parallel
on several processors (
http://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make ) If the
program doesn't build with it, please add a comment otherwise please use it.

It would also be a good idea to also add INSTALL="install -p" to the make line,
this should preserve the timestamps of the man pages.
Please also take a look at the Makefile, according to
http://koji.fedoraproject.org/koji/getfile?taskID=1092213&name=build.log the
manpages are installed twice. It's not critical now but, if I am not mistaken,
patching the Makefile in order to remove the redundant lines (if this is the
case) would be a good idea.

Did you submit any other packages ? Or maybe you have performed some
pre-reviews ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.