[Bug 507157] Review Request: efte - A lightweight, extendable, folding text editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507157


Christoph Wickert <fedora at christoph-wickert.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #7 from Christoph Wickert <fedora at christoph-wickert.de>  2009-07-01 04:24:26 EDT ---
(In reply to comment #4)
> Ugh, missing %{buildroot} before %{_bindir}. Fixed.

Ouch, I overlooked that one, too.

> > - better use pushd/popd instead of cd src/cd ..
> 
> Maybe, if the directory structure was more complicated. The stack operations
> pushd/popd seem a like an overkill :)

Not to me but it's up to you.

> > - "Categories=Development;TextEditor;" in the desktop file looks a little
> > unconventional, but I guess in this case it is correct.  
> 
> Yes, since this is an editor for programmers.

Yes, and the freedesktop spec does not know editors for programmers and thinks
all editors are utilities. For programming it only knows "IDE", but this would
really be too much for this app. Nevertheless some desktops might react a
little strange to this and show it in both categories.

> http://theory.physics.helsinki.fi/~jzlehtol/rpms/efte.spec
> http://theory.physics.helsinki.fi/~jzlehtol/rpms/efte-1.0-4.fc11.src.rpm  

Looks good and fixes all issues. efte-1.0-4.fc11.src.rpm is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.