[Bug 509533] Review Request: sap - A small CLI audio player

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=509533





--- Comment #1 from Michael Schwendt <mschwendt at gmail.com>  2009-07-04 13:02:49 EDT ---
> %install
> rm -rf $RPM_BUILD_ROOT
> sh ./build
> mkdir -p %{buildroot}%{_bindir}
>>>
> %clean
> rm -rf $RPM_BUILD_ROOT

Use either $RPM_BUILD_ROOT or %buildroot, not both at once.


> mkdir -p %{buildroot}%{_defaultdocdir}/%{name}-%{version}
> cp -p README gpl.txt %{buildroot}%{_defaultdocdir}/%{name}-%{version}

You could simply include them with %doc in the %files section:
%doc README gpl.txt


> mkdir -p %{buildroot}%{_mandir}/man1
> gzip sap.1
> cp -p sap.1.gz %{buildroot}%{_mandir}/man1

Install it uncompressed, and rpmbuild will compress it automatically.

> %{_mandir}/man1/sap.1.gz

Here prefer %{_mandir}/man1/sap.1.* as automatic compression of manual pages
makes it possible to replace gzip with a different compressor any time.


> %doc
> %{_defaultdocdir}/%{name}-%{version}
> %{_defaultdocdir}/%{name}-%{version}/README
> %{_defaultdocdir}/%{name}-%{version}/gpl.txt

These lines can be deleted in favour of the "%doc README gpl.txt"  mentioned
above.


> License: GPLv3

Actually the source files say it's "GPLv3+".

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.