[Bug 509739] Review Request: daemonize - daemonize runs a command as a Unix daemon.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=509739





--- Comment #3 from Gary T. Giesen <giesen at snickers.org>  2009-07-05 15:37:03 EDT ---
(In reply to comment #2)
> - You don't need to specify
>  -n daemonize-%{version}
> in %setup, as this is the default value.
> 
> - What is
>  $common_flags
> doing in %configure?

I had used another package spec file as a template and I believe that was some
garbage leftover.

> 
> - You are using incorrect characters in the description: change ’ to ' and “ to
> ".

Was a cut and paste from the package site. Corrected in updated spec file.

> 
> - The provide
>  Provides: daemonize

I believe I was following the convention in the template spec I was using, I
have since reviewed that particular guideline, and corrected accordingly
.
> is redundant, since by default all packages provide themself (with a versioned
> provide).
> 
> 
> I can sponsor you, if you show me you know the Fedora guidelines. You need to
> read and understand the packaging and review guidelines, and to demonstrate
> your knowledge you need to make at least one other submission, and do
> unofficial package reviews of packages of other people.  

Understood. Will submit at least one other package and submit some reviews.
I've also reviewed the packaging guidelines (again), as well as the review
guidelines (http://fedoraproject.org/wiki/Packaging/ReviewGuidelines). I
believe the updated package now meets all of those.

Thanks,

GG

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.