[Bug 508483] Review Request: ewl - Enlightenment Widget Library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508483





--- Comment #9 from John Guthrie <guthrie at counterexample.org>  2009-07-05 21:54:06 EDT ---
(In reply to comment #8)
> Thanks for the new package. I've fully reviewed the package now. In general it
> looks quite good, there are only some minor TODO items left:

Thank you for taking the time to do such a thorough review.

> * License: TODO
> - License in spec file does not match the actual license (COPYING looks like a
> variant of the MIT license)
> - however, the included spec file mentiones BSD
> - the enlightenment authors mentioned usually only BSD as the license of the
> related projects
> - I've asked fedora-legal for clarification and got a response that the
> following license field should be used:
> License: MIT with advertising
> https://www.redhat.com/archives/fedora-legal-list/2009-July/msg00003.html
> - license file packaged

When I looked at the license, I initially mis-identified it as being an BSD
license.  And then, like you saw as well, I saw other components of
enlightenment with BSD licenses.  So that led me to believe that I really had
put in the correct license.

Anyway, this is fixed.

> * package containing *.pc files must "Requires: pkgconfig": TODO
> - IMHO the usage of %if conditions should be omitted if not really needed
> - even if this may be questionable or whether in this case it would be
> meaningful, the packaging rules are indisputable here:
> http://fedoraproject.org/wiki/Packaging/Guidelines#Pkgconfig_Files
> please require pkgconfig unconditionally in the -devel package

Fair enough.  Fixed.

> * compilation: TODO
> - supports parallel build
> - RPM_OPT_FLAGS are correctly used
> - it would be better not to build the static libraries instead of deleting them
> later, please add a "--disable-static" and remove the deleting of the *.a files

Fixed.

> * main package should not contain development related parts: TODO
> /usr/lib/ewl/tests should be in -devel package

Fixed.

Here are the URLs for the new release:
http://www.guthrie.info/RPMS/f11/ewl.spec
http://www.guthrie.info/RPMS/f11/ewl-0.5.2.042-8.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.