[Bug 509806] Review Request: perl-CGI-Application-Server - Simple HTTP server for developing with CGI::Application

bugzilla at redhat.com bugzilla at redhat.com
Mon Jul 6 13:01:34 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=509806


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-07-06 09:01:33 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1456755
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
411d9acf5048e18f7f4dcae647add0c65caee715  CGI-Application-Server-0.061.tar.gz

+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=9, Tests=92,  2 wallclock secs ( 0.05 usr  0.02 sys +  1.96 cusr  0.23
csys =  2.26 CPU)
+ Package perl-CGI-Application-Server-0.061-1.fc12.noarch
Provides: perl(CGI::Application::Server) = 0.061
Requires: perl(CGI) perl(Carp) perl(HTTP::Response)
perl(HTTP::Server::Simple::Static) perl(HTTP::Status) perl(Scalar::Util)
perl(base) perl(strict) perl(warnings)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list