[Bug 508483] Review Request: ewl - Enlightenment Widget Library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508483





--- Comment #10 from Christian Krause <chkr at plauener.de>  2009-07-06 15:29:45 EDT ---
> > * License: TODO
> > - License in spec file does not match the actual license (COPYING looks like a
> > variant of the MIT license)
> > - however, the included spec file mentiones BSD
> > - the enlightenment authors mentioned usually only BSD as the license of the
> > related projects
> > - I've asked fedora-legal for clarification and got a response that the
> > following license field should be used:
> > License: MIT with advertising
> > https://www.redhat.com/archives/fedora-legal-list/2009-July/msg00003.html
> > - license file packaged
> 
> When I looked at the license, I initially mis-identified it as being an BSD
> license.  And then, like you saw as well, I saw other components of
> enlightenment with BSD licenses.  So that led me to believe that I really had
> put in the correct license.
> 
> Anyway, this is fixed.

Sorry, not 100% - the line must be exactly as I wrote:

License: MIT with advertising

> > * compilation: TODO
> > - supports parallel build
> > - RPM_OPT_FLAGS are correctly used
> > - it would be better not to build the static libraries instead of deleting them
> > later, please add a "--disable-static" and remove the deleting of the *.a files
> 
> Fixed.

Please remove the commented lines completely:
# Removing .a files
#find $RPM_BUILD_ROOT -name '*.a' -exec rm '{}' \;

> > * main package should not contain development related parts: TODO
> > /usr/lib/ewl/tests should be in -devel package
> 
> Fixed.

Unfortunately this fix has introduced a minor issue: the directory
%{_libdir}/%{name} itself is now an orphan, since it isn't included neither in
the main nor in the -devel package. Please add
%dir {_libdir}/%{name}
to the main pacakge.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.