[Bug 507052] Review Request: Panini - A tool for creating perspective views from panoramic and wide angle images

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507052





--- Comment #5 from Ankur Sinha <sanjay.ankur at gmail.com>  2009-07-07 05:49:18 EDT ---
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> >> License Field is GPLv2+ (which match source code header) but GPLv3 text file is
> >> redistributed. (need to check lastest version)
> >> 
> 
> >GPLv3. Its been clarified in the latest version.
> How ? from the source code header, none are tag as GPLv3 but GPLv2+, with the
> exeption of pvQt_QTVR.{cpp,h} which are licensed as LGPLv2+
> The binary package will ends to be GPLv2+ then! But since the GPLv3 is
> available from the svn repository, this will be more accurate to use GPLv3+ in
> the license fied anyway. So OKay.
> 

i was referring to this in the release file (panini-0.71-release.txt):

"LICENSE

Panini 0.7 is free software, copyright (C) 2008 - 2009 Thomas K Sharpless.
You can redistribute and/or modify it under the terms of the GNU General Public
License as published by the Free Software Foundation; either version 3 of the 
License, or (at your option) any later version."

Hadn't checked the source files. I'll try contacting upstream to clarify.


> ...
> > > Try to have the compiled binary / pixmaps installed with make install at
> > > %install step.  
> > 
> > I'm not sure on how to do this. The package generates a makefile using
> > qmake-qt4. I need to patch this generated makefile before make uses it??
> You will need to patch the panini.pro file.

okay. I'll try that. might take me 2-3 days to learn up qt.

> > the srpm: 
> > 
> > http://ankursinha.fedorapeople.org/panini/Panini-0.71.102-1.fc12.src.rpm
> I don't understand why having %global fname panini, then fname is only used
> once?! But this remains trivial.

I had used it more earlier. will remove it.

> Also, you could consider to clean the old comments while importing.

will do that.

> 
> FE-Legal:
> From https://bugzilla.redhat.com/show_bug.cgi?id=503252#c3 my understanding is
> that we aren't really creating panorama with this tool, but we are extracting
> perspective from already made panorama pictures. Hence, this doesn't fall under 
> any patent anyone may beleive to have.
> But I would like a confirmation from FE-Legal about this...  

okay

I'll do the other work until then

regards,

Ankur

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.