[Bug 482757] Review Request: objcryst-fox - Viewing and solving crystal structures from powder diffraction data

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482757


Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jussi.lehtola at iki.fi




--- Comment #8 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-07-08 13:10:05 EDT ---
- Use %global instead of %define. Put the revision definition at the top of the
spec file:
 %global revision R1119

- Include the revision in the release tag:
 Release:        2.%{revision}%{?dist}
(every time you update the spec file update the release tag if the version
hasn't been updated).

- No explicit Requires: are allowed for libraries; drop
 Requires:       wxGTK, fftw, freeglut
http://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires

- Drop the commented patch line
 #%patch0 -p0 

- Instead of
 find . -type d -name .svn -print0 | xargs -0r rm -rf
you can just use
 find . -name *.svn -exec rm -rf {} \;
(or maybe even
 find . -name *.svn -delete;
)

- Preserve time stamps by adding -p to install commands.

- Use "rm" instead of "unlink".

- Install the pixmap to /usr/share/pixmaps, drop the hicolor stuff. (Also, you
were missing Requires: hicolor-icon-theme.)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.