[Bug 480103] Review Request: bnIRC - An ncurses based IRC client and modular IRC framework.(Need Sponsorship. First time Packager)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480103





--- Comment #18 from Michael Schwendt <mschwendt at gmail.com>  2009-07-09 02:39:18 EDT ---
* It fails to build on Fedora 11:

| channel.c:146: warning: conflicting types for built-in function 'log'
| user.c: In function 'users_in_channel':
| user.c:299: warning: passing argument 4 of 'qsort' from incompatible pointer
type
/usr/include/stdlib.h:710: note: expected '__compar_fn_t' but argument is of
type 'int (*)(void *, void *)'
| regex.c:34: error: static declaration of 'strndup' follows non-static
declaration
| make[1]: *** [regex.lo] Error 1

Indeed, regex.c includes <string.h> and declares its own one just a few lines
further down in the file.


* It doesn't adhere to the compiler flags guidelines:
  https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags

The flags you should see in the build log are those printed by "rpm --eval
%{optflags}". Since %configure exports them (see "rpm --eval %configure"), but
the bnirc source tarball doesn't accept the variables passed in from the
outside, it may be necessary to apply a patch.


* Issues pointed out in bottom of comment 10 are not fixed yet.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.