[Bug 246525] Review Request: libMini - A high-performance terrain rendering library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=246525





--- Comment #32 from Rick L Vinyard Jr <rvinyard at cs.nmsu.edu>  2009-07-13 10:51:31 EDT ---
(In reply to comment #31)
> Quick notes:
> - Why OpenThreads-devel can be enabled ?

Upstream supports it.

> - Does GREYCStoration could be usefull ?

Not sure. But, it doesn't look like Fedora already has a GREYCstoration library
(just the app and GIMP plugin), and I'm not sure it would be worth packaging
one. The GREYCstoration home page says the project is about to die:
http://cimg.sourceforge.net/greycstoration/

> - switch to rm -rf GL (moved from Mini/GL to GL)

Fixed.

> - squish (if enabled) should uses pkg-config support, I was not able to enable
> squish support as there is a missing -lsquish at link time. (not needed for
> this review).

I didn't suggest that to upstream because, as distributed, squish doesn't have
pkgconfig support. That was something I added to the libsquish packages before
the issue of patents came up.

> - Is it possible to avoid using the whole autogen.sh ? Given the recent
> discution on fedora-devel, it will always be best to avoid usage of autotools
> at build step.

It will with the next upstream release. The need for autotools at build is due
to the configure.ac patch to 9.0.3 which upstream has already accepted into
svn. But, I'd rather build against a stable release and patch than build
against svn.

> - It would be better to use one BuildRequires per line (easier to see BR
> changes on cvs commit).
> 

Fixed

> Build time and usage test succeed.  

I've also submitted some patches to upstream's Yukon and Stuttgart applications
that build against libMini. Those have been accepted and are released.

I'll submit those for review later today. They're small and straightforward but
provide a good way to not only test libMini builds, but provide a way for the
developer to check out the library via a graphical application.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.