[Bug 507943] Review Request: moblin-gtk-engine - GTK engine for Moblin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507943





--- Comment #7 from Peter Robinson <pbrobinson at gmail.com>  2009-07-13 15:38:53 EDT ---

> If you're using a git tarball, then you need to adjust the version and release
> accordingly.
> http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages
> 
> Judging from the URL this seems to be a stable release. However the git part
> makes me think this is a daily snapshot. If it is, then you should get the
> source from git:
> http://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control

Its a proper release but the moblin guys don't currently release tarballs so
only do it via the git method (very annoying but getting more common now days).
Because they are tagged releases the tarballs are able to be recreated by
downloading them so they don't require the pre-release tagging (like for eg the
geoclue package I maintain).

> > > MUST: Optflags are used and time stamps preserved. NEEDSWORK
> > > - Time stamps are lost during install. Adding INSTALL="install -p" as argument
> > > to make install should do the trick.
> > 
> > I couldn't find anything about this in packaging guidelines.
> 
> It's sort of implicitly assumed in
> https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps
> 
> I sent a request to add the mention of it to the FPC.

OK, I'll update it when its in the packaging guidelines. I don't see that it
should block the review as I only see it there when copying files within the
install section. The only one that does that is the utf-8 stuff which preserves
it as per the details you provided above.

> > > MUST: All relevant items are included in %doc. Items in %doc do not affect
> > > runtime of application. NEEDSWORK
> > > - Missing WORK.
> > 
> > Not sure what's missing here. There's no WORK file. I've added the NEWS file.
> 
> Ugh. That's what I meant :)  

:-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.