[Bug 491694] Review Request: Anyterm - Web based terminal emulator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=491694





--- Comment #26 from Alexander Boström <abo at root.snowtree.se>  2009-07-15 09:19:18 EDT ---
(In reply to comment #25)
> (In reply to comment #24)

> > Hmm, you're right. A subpackage would be fine. Another option is to just put
> > anyterm.conf in %doc since it asks to be edited anyway.
> 
> I created a anyterm-httpd subpackage, that depends on anyterm and httpd, and
> just contains the anyterm / httpd proxy config.

Cool, though there's

 * SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.

It's only a SHOULD. I don't know if it matters.

> Done, useradd and groupadd no longer redirected stderr.

Good enough, though the redirect of stdout for those seems superfluous.


Also, some new rpmlints:

anyterm.src:111: E: files-attr-not-set
I think you need a defattr for each subpackage.

anyterm.src:120: W: macro-in-%changelog doc
Edit the changelog to say %%doc.

anyterm-httpd.i586: W: summary-not-capitalized httpd proxy configuration for
anyterm
It seem wrong to capitalize a package name.

anyterm-httpd.i586: W: no-documentation
There's not much documentation to include. It's all on the web site.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.