[Bug 508511] Review Request: python-Lightbox - Lightbox photo display widget

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508511





--- Comment #5 from Parag AN(पराग) <panemade at gmail.com>  2009-07-17 00:37:32 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1481057
+ rpmlint output on SRPM and for RPM.
python-Lightbox.src: E: description-line-too-long Lightbox is a TurboGears
widget wrapper for the Lightbox2 JavaScript library by Lokesh Dhakar.
python-Lightbox.src: E: description-line-too-long It displays a thumbnail image
which, when clicked, opens an overlay popup window for viewing
python-Lightbox.src: E: description-line-too-long the linked image in full
size. You can also browse through several Lightbox images that are
python-Lightbox.noarch: E: description-line-too-long Lightbox is a TurboGears
widget wrapper for the Lightbox2 JavaScript library by Lokesh Dhakar.
python-Lightbox.noarch: E: description-line-too-long It displays a thumbnail
image which, when clicked, opens an overlay popup window for viewing
python-Lightbox.noarch: E: description-line-too-long the linked image in full
size. You can also browse through several Lightbox images that are
python-Lightbox.noarch: E: script-without-shebang
/usr/lib/python2.6/site-packages/lightbox/static/css/lightbox.css
python-Lightbox.noarch: E: script-without-shebang
/usr/lib/python2.6/site-packages/lightbox/static/javascript/lightbox.js

+ source files match upstream url
82d970d81261efa020071e4507a284aeb866e5d7  Lightbox-2.1.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.

Provide updated SRPM which will fix also comment #1
Fix rpmlint messages

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.