[Bug 512497] Review Request: Bleachbit - Remove unnecessary files, free space, and maintain privacy

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=512497


Fabian Affolter <fabian at bernewireless.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fabian at bernewireless.net




--- Comment #1 from Fabian Affolter <fabian at bernewireless.net>  2009-07-18 04:53:52 EDT ---
Just some comments after a quick look at your spec file:

- Isn't 'gettext' missing as a BR?
- 'make' is not needed as a BR
  https://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2
- '-n %{name}-%{version}' in the %setup section is not needed, this is the
default
- What tell rpmlint about the line length in the %description?
- You should use only 'desktop-file-install' or 'desktop-file-validate' not
both
 
https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.