[Bug 459161] Review Request: wraplinux - Utility to wrap a Linux kernel and initrd into an ELF or NBI file

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459161





--- Comment #7 from Rahul Sundaram <sundaram at redhat.com>  2009-07-19 12:16:14 EDT ---
Writing down makes no real difference to me. There has been instances of people
blindly copy pasting templates and still overlooking checklist items. Again,
instead of approaching it on a case by case basis, if you feel strongly about
how reviews should be done, it is better to take it to the packaging committee
or FESCo and make it part of the guidelines/rules. Otherwise it is just
individual's freedom to do the reviews as they see fit. 

I would also note that packaging is primarily the responsibility of the package
maintainers. Reviewers are merely volunteering to help out with the process as
QA assistance. Mistakes are bound to happen either way even with a recheck.
Just to demonstrate, I checked the copyright notices again, GPLv2+ doesn't seem
the right choice here either. reloc_linux.c seems to be under the MIT license
actually and xmalloc.c doesn't even have a license notice. Warren, I suggest
you contact upstream and clarify these.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.