[Bug 512270] Review Request: quitcount - A tool for people who quit smoking

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=512270





--- Comment #4 from Fabian Affolter <fabian at bernewireless.net>  2009-07-19 12:17:06 EDT ---
(In reply to comment #3)
> Issues:
> License tag wrong, see above

fixed

> Icon in the launcher is missing because Icon cache is not being updated, see
> https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache

fixed

> What's the use of:
> mv %{buildroot}/etc/xdg/autostart/%{name}.desktop
> %{buildroot}/%{_datadir}/applications/
> desktop-file-install                                        \
>     --dir=%{buildroot}%{_datadir}/applications              \
>     %{buildroot}/%{_datadir}/applications/%{name}.desktop
> 
> Note you are hardcoding /etc here. Why not simply use: 
> desktop-file-install                                        \
>     --dir=%{buildroot}%{_datadir}/applications              \
>     --delete-original                                       \
>     %{buildroot}/%{_sysconfdir}/xdg/autostart/%{name}.desktop
> 
> IMO the package should be autostarted, because the tray icon is a reminder to
> actually quit smoking. Remove "--delete-original" and you are done.  

fixed.  Yes, the application should autostart.

Update files:
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/quitcount.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/quitcount-1.4.1-2.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.