[Bug 507089] Review Request: olpc-powerd - power management for the XO laptop

bugzilla at redhat.com bugzilla at redhat.com
Mon Jul 20 14:32:50 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507089





--- Comment #7 from Paul Fox <pgf at laptop.org>  2009-07-20 10:32:48 EDT ---

i believe i've addressed all of the FIX issues listed above.

rpmlint now gives 0 warnings/0 errors -- however, my development machine is
currently fedora 9.  i did nothing for the "false positive" error that cwickert
reported.  

regarding comment #5, for the "unsafe" rm -- i changed powerd to clean up after
itself, so that the rm in the uninstall is no longer needed.

i had the best intentions of testing the install/remove/upgrade paths for the
scriptlets this weekend, but was not able to.  i agree, given my reading of the
spec, with cwickert's proposed implementation in comment #4, and have applied
it verbatim.

so:  here are the new pre-release srpm and spec:

http://dev.laptop.org/~pgf/rpms/srpms/olpc-powerd-8-1.20090720git702fd8e.src.rpm
 http://dev.laptop.org/~pgf/rpms/srpms/olpc-powerd.spec-8-1.20090720git702fd8e

and an f-9 rpm:

http://dev.laptop.org/~pgf/rpms/olpc-powerd-8-1.20090720git702fd8e.fc9.i386.rpm

i will test at earliest opportunity, but if someone else tests sooner, please
let me know.

many thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list