[Bug 507958] Review Request: eclipse-rse - Eclipse Remote System Explorer framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507958





--- Comment #2 from Jeff Johnston <jjohnstn at redhat.com>  2009-07-20 17:16:46 EDT ---
(In reply to comment #1)
> Thanks for the submission, Jeff.  A few comments:
> 
> - I think you're missing Requires on eclipse-cdt and eclipse-emf

done

> - will we move to 3.1 once we get a Galileo CDT build?

Yes.  CDT 6.0 only requires RSE >= 3.0.

> - please use either %{buildroot} or $RPM_BUILD_ROOT but not both

done

> - we should perhaps have Eclipse in the Summary field

done

> - I think "framework" can be dropped from the Summary field

ok, done

> - please change the permissions on the fetch script to avoid this rpmlint
> warning:
> 
> eclipse-rse.src: W: strange-permission fetch-rse.sh 0775
> 

done

> - you should probably mark a top-level feature's about.html as %doc

done.  I get a warning about file being specified twice, but I don't see any
other examples in any of the other eclipse projects.

> - you should look for @build@ and replace it with the same qualifier that
> upstream uses.  In fact, you should use forceContextQualifier (see
> eclipse-mylyn.spec for an example) to ensure our versions are the same as
> upstream's for 3.0.3
> 

I can't use forceContextQualifier because the versions are being set by map
files.  The RSE project has many version qualifiers for the various plugins and
features.  It does not create a single build id for a release and none of the
qualifiers are filled in for the various tags.  I have fixed this by using the
map files to a) fetch the plugins/features for the tarball b) create a
featureVersions.properties and pluginVersions.properties file from the same map
files.  Both a and b are performed in the fetch-rse.sh script.  The build now
matches the upstream version numbers, including the suffixes which are used for
features.  I have opened an RFE for pdebuild to allow map files to be specified
which should make this easier for future rpm packaging.

> The package builds for me, follows the packaging guidelines, and functions in
> Eclipse.  Thanks for the high quality submission.  Once the minor issues above
> are cleaned up, I will approve this.  

Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.