[Bug 509310] Review Request: gpointing-device-settings - Configuration tool for pointing devices

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=509310





--- Comment #10 from Gianluca Sforna <giallu at gmail.com>  2009-07-20 19:40:58 EDT ---
OK, applied some changes (same SPEC URL)

Added Obsoletes/Provides gsynaptics (please double check those)

(In reply to comment #9)
> Before I post the full review, here are some issues I've found so far:
> 
> * sources: TODO
> - please fix Source0 according to the example in the guidelines:
> http://fedoraproject.org/wiki/Packaging:SourceURL
> (you should also verify that spectool -g works correctly and retrieves the
> source file

Fixed, but unfortunately I can't use the common example with sf.jp

> 
> * subpackage for libgpds: TODO
> - the naming is not consistent:
> packagename: libgpds
> library name: libgpds (incl. SONAME)
> include path for header files: /usr/include/gpointing-device-settings
> pkgconfig file: libgpointing-device-settings.pc
> library flags in the pkgconfig file: -lgpointing-device-settings
> - at least the last problem must be fixed - otherwise the pkgconfig file can't
> be used to link anything against this library
> - preferably also the include path and the pkgconfig file name could be fixed
> 
I am not sure how should I fix that. any pointers?


> * BuildRequires: TODO
> - if there is no specific reason, only gettext (and not gettext-devel) should
> be a BR

Fixed

> 
> * package owns all directories that it creates: TODO
> - files are copied into /usr/lib/gnome-settings-daemon-2.0, but it is neither
> owned by this package nor is the owner of this directory required
> - I suggest to add: Requires: gnome-settings-daemon

good catch: added

> 
> * the corresponding gsynaptics configuration dialog has a menu item in System
> -> Preferences -> Touchpad
> - IMHO the same should be done for gpointing-device-settings - please create an
> appropriate *.desktop file  

As far as I understand it, that is something like a test program I'd rather not
expose to end users in the menu

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.