[Bug 512639] Review Request: ibus-table-translit - Translit table for IBus Table.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=512639





--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-07-21 02:47:12 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1488960
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
fa34ab48dc174452c4d667ac9384d39727497190 
ibus-table-translit-1.2.0.20090720.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ ibus-table-createdb scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application

Suggestion:
1) use configure instead autogen.sh
2)you already requires ibus-table then what is need to own 
%dir %{_datadir}/ibus-table
%dir %{_datadir}/ibus-table/icons
%dir %{_datadir}/ibus-table/tables
3)drop
BuildRequires:    gettext-devel >= 0.17, automake >= 1.10

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.