[Bug 513083] Review Request: gbirthday - birthday reminder for evolution

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513083


Christoph Wickert <fedora at christoph-wickert.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora at christoph-wickert.de




--- Comment #2 from Christoph Wickert <fedora at christoph-wickert.de>  2009-07-21 21:39:54 EDT ---
Thanks for your submission. The license definitely is a blocker, because not
all versions of the GPL are compatible with other licenses, see
https://fedoraproject.org/wiki/Licensing#GPLCompatibilityMatrix

We need to now what version is is and if it is a single version only (e.g.
GPLv2) or "any later version (GPLv2+). Please contact the author and ask him to
clarify the license and to incluse both a COPYING file and a license block in
the header of the programm itself in the next release.

Some more comments:

Source0 should be 
http://downloads.sourceforge.net/gbirthday/gbirthday-%{version}.tar.gz
Use the macro %{version} here, so you don't have to update the URL on every
update.

Your makefile and the skript itself contain hardcoded paths like "/usr/share".

"Applications/Internet" doesn't seem to be the right group to me, "User
Interface/Desktops" seems more adequate. See 
/usr/share/doc/rpm*/GROUPS for a list of known groups.

The patch should follow the format <name>-patchname.patch
%{name}-%{version}-patchname.patch, where {version} is the version of gbirthday
where the patch was introduced. When you reference the patch in the spec, do
not use a macro but 0.4.1 instead, because the name of the patch is not
(necessarily) changing from release to release.

If your patch is good, send it upstream.

%{_datadir}/gbirthday/* is bad, because the folder %{_datadir}/gbirthday/ is
not included and will remain on the disk after removal of the package.

Use desktop-file-install or desktop-file-validate for gbirthday.desktop, see
https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files

With desktop-file-install you could also add a copy of gbirthday.desktop to
/etc/xdg/autostart, so the reminder starts automatically.

There is still a lot of room for improvement, but I'M sure we can work this
out.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.