[Bug 513083] Review Request: gbirthday - birthday reminder for evolution

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513083


Fabian Affolter <fabian at bernewireless.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fabian at bernewireless.net




--- Comment #4 from Fabian Affolter <fabian at bernewireless.net>  2009-07-22 13:34:38 EDT ---
Sorry that I interfere, just two quick comments:

- You are mixing '%{buildroot}' and '$RPM_BUILD_ROOT'
 
https://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS
- There is a entry in the changelog that indicate that there are translations.
  https://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files

(In reply to comment #3)
> Don't know, if this needs to bumb the Release, because it's not already
> packaged, but did so:

Every time you make a change in the spec file bump the release, no confusions
and everybody can see/read what was changed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.