[Bug 512068] Review Request: rancid - Really Awesome New Cisco confIg Differ

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=512068


David Nalley <david at gnsa.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #17 from David Nalley <david at gnsa.us>  2009-07-22 23:27:47 EDT ---
I tend to agree with lack of telnet and rsh, but I don't think that blocks the
package, more of a preference than anything, so not within scope of the package
review. 

provides and requires looks sane:

[ke4qqq at nalleyt61 i586]$ rpm -qp --provides ./rancid-2.3.2-3.fc11.i586.rpm 
config(rancid) = 2.3.2-3.fc11
rancid = 2.3.2-3.fc11
rancid(x86-32) = 2.3.2-3.fc11
[ke4qqq at nalleyt61 i586]$ rpm -qp --requires ./rancid-2.3.2-3.fc11.i586.rpm 
/bin/sh  
/bin/sh  
/usr/bin/expect  
/usr/bin/perl  
config(rancid) = 2.3.2-3.fc11
expect  
findutils  
iputils  
libc.so.6  
libc.so.6(GLIBC_2.0)  
libc.so.6(GLIBC_2.3)  
libc.so.6(GLIBC_2.3.4)  
libc.so.6(GLIBC_2.4)  
libutil.so.1  
libutil.so.1(GLIBC_2.0)  
logrotate  
perl  
perl >= 1:5
perl(CGI)  
perl(Getopt::Std)  
perl(LockFile::Simple)  
perl(Mail::Mailer)  
perl(POSIX)  
perl(Sys::Syslog)  
perl(newgetopt.pl)  
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rtld(GNU_HASH)  
shadow-utils  

As you noted rpmlint still complaining about permissions - but doesn't appear
to be a blocker. 

[ke4qqq at nalleyt61 i586]$ rpmlint ../../SPECS/rancid.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
[ke4qqq at nalleyt61 i586]$ rpmlint ../../SRPMS/rancid-2.3.2-3.fc11.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[ke4qqq at nalleyt61 i586]$ rpmlint ./rancid-2.3.2-3.fc11.i586.rpm 
rancid.i586: W: non-standard-uid /etc/rancid/lg.conf rancid
rancid.i586: W: non-standard-gid /etc/rancid/lg.conf rancid
rancid.i586: E: non-readable /etc/rancid/lg.conf 0640
rancid.i586: W: non-standard-uid /etc/rancid/rancid.conf rancid
rancid.i586: W: non-standard-gid /etc/rancid/rancid.conf rancid
rancid.i586: E: non-readable /etc/rancid/rancid.conf 0640
rancid.i586: W: non-standard-uid /var/rancid rancid
rancid.i586: W: non-standard-gid /var/rancid rancid
rancid.i586: E: non-standard-dir-perm /var/rancid 0750
rancid.i586: W: non-standard-uid /etc/rancid rancid
rancid.i586: W: non-standard-gid /etc/rancid rancid
rancid.i586: E: non-standard-dir-perm /etc/rancid 0750
rancid.i586: W: non-standard-uid /var/log/rancid/old rancid
rancid.i586: W: non-standard-gid /var/log/rancid/old rancid
rancid.i586: E: non-standard-dir-perm /var/log/rancid/old 0750
rancid.i586: W: non-standard-uid /var/log/rancid rancid
rancid.i586: W: non-standard-gid /var/log/rancid rancid
rancid.i586: E: non-standard-dir-perm /var/log/rancid 0750
1 packages and 0 specfiles checked; 6 errors, 12 warnings.
[ke4qqq at nalleyt61 i586]$ rpmlint ./rancid-debuginfo-2.3.2-3.fc11.i586.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Thanks for doing the work on this. 
I don't see any blockers for approving the package thus: 

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.