[Bug 513541] Review Request: cpulimit - CPU Usage Limiter for Linux

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513541


Fabian Affolter <fabian at bernewireless.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fabian at bernewireless.net




--- Comment #1 from Fabian Affolter <fabian at bernewireless.net>  2009-07-24 03:24:44 EDT ---
Just some quick comments on your spec file:

You wrote in your sec file...
----%>------
#The source on sourceforge does not use autotools. Source1 does
Source0:       
http://downloads.sourceforge.net/project/cpulimit/cpulimit/cpulimit/cpulimit-1.1.tar.gz 
Source1:        http://ashay.info/rpm/cpulimit-1.1.tar.gz
----<%------

Have you make a patch for the usage of autotools? If yes, send this patch
upstream and apply the patch in the spec file.

https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25prep_section:_.25patch_commands

There are more details available about 'Source0'

https://fedoraproject.org/wiki/How_to_create_an_RPM_package#Spec_file_pieces_explained
look for 'Source0'

- 'Source0' seems to be wrong, shouldn't it be
'http://downloads.sourceforge.net/cpulimit/%{name}-%{version}.tar.gz' ?

- For valid groups you can use 'less /usr/share/doc/rpm-*/GROUPS'

-  %attr (-,root,root) can be left away, it sufficient only to use
%{_mandir}/*/* 

- Isn't rpmlint complaining about the line length of the %description?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.