[Bug 226078] Merge Review: libxklavier

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226078


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |mclasen at redhat.com,
                   |                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review?




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-07-24 06:45:55 EDT ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1497503
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
37c6e9fb8b436d6a646a6eea09cf196baad28756  libxklavier-4.0.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ libxklavier.pc file present.
+ -devel subpackage present.
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ ldconfig scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package  libxklavier-4.0-3.fc12.i686=>
Provides: libxklavier.so.15
Requires: libX11.so.6 libXi.so.6 libc.so.6 libc.so.6(GLIBC_2.0)
libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.2)
libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libglib-2.0.so.0
libgobject-2.0.so.0 libxkbfile.so.1 libxklavier.so.15 libxml2.so.2
rtld(GNU_HASH)
+ Package libxklavier-devel-4.0-3.fc12.i686 =>
Provides: pkgconfig(libxklavier) = 4.0
Requires: /usr/bin/pkg-config libxklavier.so.15 pkgconfig(libxml-2.0)

+ Not a GUI application

Should:
1) follow http://fedoraproject.org/wiki/PackagingGuidelines#Timestamps

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.