[Bug 478372] Review request: Mathgl - Scientific plotting library.

bugzilla at redhat.com bugzilla at redhat.com
Sun Jul 26 09:23:58 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478372





--- Comment #19 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-07-26 05:23:55 EDT ---
Removing rpath:
http://fedoraproject.org/wiki/Packaging/Guidelines#Removing_Rpath
* you're running autoreconf, so --disable-rpath to configure should work.
* the second option has worked always in my case (also works flawlessly in
version upgrades and so on):
 %configure
 sed -i 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g'
libtool
 sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool

Please use one of these instead of chrpath, which is the very last option.

**

Usually we don't fix SMP make (at least when it requires regenerating
autotools). Just send the patches upstream, drop Patch1 and its BRs and comment
the %{?_smp_mflags} part with a note that it doesn't work in 1.9.

**

The package containing the octave plugin must
 Requires: octave(api) = %{octave_api}

drop the octave site stuff
 #Create a symlink in octave's path, so plugin gets detected by octave
 mkdir -p 
  $RPM_BUILD_ROOT/%{_prefix}/libexec/octave/site/%{octave_api}/%{octave_type}/
 cd
$RPM_BUILD_ROOT/%{_prefix}/libexec/octave/site/%{octave_api}/%{octave_type}/ 
 ln -s %{_prefix}/libexec/octave/plugins/%{name}/%{octave_type}-
  %{octave_api}/%{name}.oct 

and run the following commands to regenerate the octave package database:
 %post
 octave -q -H --no-site-file --eval "pkg('rebuild');"
 %postun
 octave -q -H --no-site-file --eval "pkg('rebuild');"

**

Drop the definition of octtype as you're not using it, and change the %define's
into %global's.
http://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define

**

Put the info files in the main package. 

**

You might not want to remove the zero-length files as if some of them are
missing the program might not work. Best to ask upstream to remove the empty
files from the distribution.

**

Remove the documentation 'make install' installs in %{_docdir}/%{name} with
 rm -rf %{_docdir}/%{name}
instead just list the necessary files in the %doc of the -doc subpackage.

**

You need to regenerate the info database as well:
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Texinfo

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list