[Bug 511212] Review Request: cluster-glue - reusable clustering components

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=511212


Fabio Massimo Di Nitto <fdinitto at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fdinitto at redhat.com




--- Comment #12 from Fabio Massimo Di Nitto <fdinitto at redhat.com>  2009-07-27 07:13:39 EDT ---
Hi guys,

I did run through a review of cluster-glue.

rpmlint output:

[fabbione at daitarn-fedora rpmbuild]$ rpmlint SPECS/cluster-glue.spec
SRPMS/cluster-glue-0.9-4.fc12.src.rpm RPMS/x86_64/cluster-glue-*
cluster-glue.x86_64: E: non-standard-dir-perm /var/lib/heartbeat/cores/nobody
0700
cluster-glue.x86_64: E: non-standard-dir-perm /var/lib/heartbeat/cores/root
0700
cluster-glue.x86_64: E: non-standard-dir-perm /var/lib/heartbeat/cores/daemon
0700
5 packages and 1 specfiles checked; 3 errors, 0 warnings.

For the record:

SHOULD: Usually, subpackages other than devel should require the base package
using a fully versioned dependency. [22]

the -devel package Requires: %{name} = %{version}-%{release}

If this is done on purpose it should be documented in the spec file otherwise
dropped.

SHOULD: The reviewer should test that the package builds in mock. [29]

For some reasons mock is busted in rawhide and I am unable to perform this
check. The package builds fine in an installed rawhide machine.

The package passes all the checklist for ReviewGuidelines.

Kevin: I hope this can help speed up the process.

Fabio

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.