[Bug 513286] Review Request: condor-ec2-enhanced - EC2 Enhanced AMI package
bugzilla at redhat.com
bugzilla at redhat.com
Mon Jul 27 17:32:44 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513286
Nuno Santos <nsantos at redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |nsantos at redhat.com
AssignedTo|nobody at fedoraproject.org |nsantos at redhat.com
--- Comment #1 from Nuno Santos <nsantos at redhat.com> 2009-07-27 13:32:42 EDT ---
There are a few issues that need to be corrected, highlighted by "!!!" below:
condor-ec2-enhanced-1.0-13.fc10.src.rpm
MUST Items:
* MUST: rpmlint must be run on every package. The output should be posted in
the review.
!!!
$ rpmlint condor-ec2-enhanced-1.0-13.fc10.src.rpm
condor-ec2-enhanced.src: E: no-cleaning-of-buildroot %install
condor-ec2-enhanced.src: E: no-cleaning-of-buildroot %clean
condor-ec2-enhanced.src: W: no-%build-section
condor-ec2-enhanced.src: W: no-%clean-section
1 packages and 0 specfiles checked; 2 errors, 2 warnings.
!!!
$ rpmlint
/home/nsantos/rpmbuild/RPMS/noarch/condor-ec2-enhanced-1.0-13.fc11.noarch.rpm
condor-ec2-enhanced.noarch: W: dangerous-command-in-%post mv
condor-ec2-enhanced.noarch: W: missing-lsb-keyword Default-Stop in
/etc/rc.d/init.d/condor-ec2-enhanced
condor-ec2-enhanced.noarch: W: incoherent-subsys
/etc/rc.d/init.d/condor-ec2-enhanced $prog
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
* MUST: The package must be named according to the Package Naming Guidelines .
OK
* MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
OK
* MUST: The package must meet the Packaging Guidelines .
!!!
missing %clean section
* MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
OK (ASL 2.0)
* MUST: The License field in the package spec file must match the actual
license.
OK
* MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the
text of the license(s) for the package must be included in %doc.
OK
* MUST: The spec file must be written in American English.
OK
* MUST: The spec file for the package MUST be legible.
OK
* MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL.
Reviewers should use md5sum for this task. If no upstream URL can be
specified for this package,
please see the Source URL Guidelines for how to deal with this.
!!!
missing upstream information (see
http://fedoraproject.org/wiki/Packaging/SourceURL for details)
* MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
OK
$ rpmbuild -ba condor-ec2-enhanced.spec
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.yvsoqK
+ umask 022
+ cd /home/nsantos/rpmbuild/BUILD
+ LANG=C
+ export LANG
+ unset DISPLAY
+ cd /home/nsantos/rpmbuild/BUILD
+ rm -rf condor-ec2-enhanced-1.0
+ /usr/bin/gzip -dc
/home/nsantos/rpmbuild/SOURCES/condor-ec2-enhanced-1.0-13.tar.gz
+ /bin/tar -xf -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd condor-ec2-enhanced-1.0
+ /bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ echo 'Patch #0 (chkconfig_off.patch):'
Patch #0 (chkconfig_off.patch):
+ /bin/cat /home/nsantos/rpmbuild/SOURCES/chkconfig_off.patch
+ /usr/bin/patch -s -p1 --fuzz=0
+ exit 0
Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.GUH0KC
+ umask 022
+ cd /home/nsantos/rpmbuild/BUILD
+ '[' /home/nsantos/rpmbuild/BUILDROOT/condor-ec2-enhanced-1.0-13.fc11.i386
'!=' / ']'
+ rm -rf /home/nsantos/rpmbuild/BUILDROOT/condor-ec2-enhanced-1.0-13.fc11.i386
++ dirname
/home/nsantos/rpmbuild/BUILDROOT/condor-ec2-enhanced-1.0-13.fc11.i386
+ mkdir -p /home/nsantos/rpmbuild/BUILDROOT
+ mkdir /home/nsantos/rpmbuild/BUILDROOT/condor-ec2-enhanced-1.0-13.fc11.i386
+ cd condor-ec2-enhanced-1.0
+ LANG=C
+ export LANG
+ unset DISPLAY
+ mkdir -p
/home/nsantos/rpmbuild/BUILDROOT/condor-ec2-enhanced-1.0-13.fc11.i386/usr/sbin
+ mkdir -p
/home/nsantos/rpmbuild/BUILDROOT/condor-ec2-enhanced-1.0-13.fc11.i386//etc/condor
+ mkdir -p
/home/nsantos/rpmbuild/BUILDROOT/condor-ec2-enhanced-1.0-13.fc11.i386//etc/rc.d/init.d
+ cp -f caroniad
/home/nsantos/rpmbuild/BUILDROOT/condor-ec2-enhanced-1.0-13.fc11.i386//usr/sbin
+ cp -f config/caroniad.conf
/home/nsantos/rpmbuild/BUILDROOT/condor-ec2-enhanced-1.0-13.fc11.i386//etc/condor
+ cp -f config/condor-ec2-enhanced.init
/home/nsantos/rpmbuild/BUILDROOT/condor-ec2-enhanced-1.0-13.fc11.i386//etc/rc.d/init.d/condor-ec2-enhanced
+ /usr/lib/rpm/check-buildroot
+ /usr/lib/rpm/redhat/brp-compress
+ /usr/lib/rpm/redhat/brp-strip /usr/bin/strip
+ /usr/lib/rpm/redhat/brp-strip-static-archive /usr/bin/strip
+ /usr/lib/rpm/redhat/brp-strip-comment-note /usr/bin/strip /usr/bin/objdump
+ /usr/lib/rpm/brp-python-bytecompile
+ /usr/lib/rpm/redhat/brp-python-hardlink
+ /usr/lib/rpm/redhat/brp-java-repack-jars
Processing files: condor-ec2-enhanced-1.0-13.fc11.noarch
Executing(%doc): /bin/sh -e /var/tmp/rpm-tmp.WtKYGv
+ umask 022
+ cd /home/nsantos/rpmbuild/BUILD
+ cd condor-ec2-enhanced-1.0
+
DOCDIR=/home/nsantos/rpmbuild/BUILDROOT/condor-ec2-enhanced-1.0-13.fc11.i386/usr/share/doc/condor-ec2-enhanced-1.0
+ export DOCDIR
+ rm -rf
/home/nsantos/rpmbuild/BUILDROOT/condor-ec2-enhanced-1.0-13.fc11.i386/usr/share/doc/condor-ec2-enhanced-1.0
+ /bin/mkdir -p
/home/nsantos/rpmbuild/BUILDROOT/condor-ec2-enhanced-1.0-13.fc11.i386/usr/share/doc/condor-ec2-enhanced-1.0
+ cp -pr LICENSE-2.0.txt
/home/nsantos/rpmbuild/BUILDROOT/condor-ec2-enhanced-1.0-13.fc11.i386/usr/share/doc/condor-ec2-enhanced-1.0
+ exit 0
Provides: config(condor-ec2-enhanced) = 1.0-13.fc11
Requires(interp): /bin/sh /bin/sh /bin/sh
Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <=
4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
Requires(post): /bin/sh /sbin/chkconfig
Requires(preun): /bin/sh /sbin/chkconfig /sbin/service
Requires(postun): /bin/sh /sbin/service
Requires: /usr/bin/python
Checking for unpackaged file(s): /usr/lib/rpm/check-files
/home/nsantos/rpmbuild/BUILDROOT/condor-ec2-enhanced-1.0-13.fc11.i386
Wrote: /home/nsantos/rpmbuild/SRPMS/condor-ec2-enhanced-1.0-13.fc11.src.rpm
Wrote:
/home/nsantos/rpmbuild/RPMS/noarch/condor-ec2-enhanced-1.0-13.fc11.noarch.rpm
* MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures
should be listed in the spec in ExcludeArch. Each architecture listed in
ExcludeArch MUST have a bug filed in bugzilla,
describing the reason that the package does not compile/build/work on that
architecture.
The bug number MUST be placed in a comment, next to the corresponding
ExcludeArch line.
N/A
* MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section
of the Packaging Guidelines ; inclusion of those as BuildRequires is
optional. Apply common sense.
* MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro.
Using %{_datadir}/locale/* is strictly forbidden.
N/A
* MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any
of the dynamic linker's default paths, must call ldconfig in %post and
%postun.
N/A
* MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review,
along with the rationalization for relocation of that specific package.
Without this, use of Prefix: /usr is considered a blocker.
N/A
* MUST: A package must own all directories that it creates. If it does not
create a directory that it uses,
then it should require a package which does create that directory.
OK
* MUST: A Fedora package must not list a file more than once in the spec file's
%files listings.
OK
* MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example.
Every %files section must include a %defattr(...) line.
OK
* MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
!!!
missing %clean section
* MUST: Each package must consistently use macros.
OK
* MUST: The package must contain code, or permissable content.
OK
* MUST: Large documentation files must go in a -doc subpackage. (The definition
of large is left up to the packager's best judgement,
but is not restricted to size. Large can refer to either size or quantity).
N/A
* MUST: If a package includes something as %doc, it must not affect the runtime
of the application.
To summarize: If it is in %doc, the program must run properly if it is not
present.
OK
* MUST: Header files must be in a -devel package.
N/A
* MUST: Static libraries must be in a -static package.
N/A
* MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
(for directory ownership and usability).
N/A
* MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so
(without suffix) must go in a -devel package.
N/A
* MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned
dependency: Requires: %{name} = %{version}-%{release}
OK
* MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
OK
* MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly
installed with desktop-file-install in the %install section. If you feel
that your packaged GUI application
does not need a .desktop file, you must put a comment in the spec file with
your explanation.
N/A
* MUST: Packages must not own files or directories already owned by other
packages. The rule of thumb here is that the
first package to be installed should own the files or directories that other
packages may rely upon.
This means, for example, that no package in Fedora should ever share ownership
with any of the files or directories
owned by the filesystem or man package. If you feel that you have a good
reason to own a file or directory that
another package owns, then please present that at package review time.
OK
* MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}
(or $RPM_BUILD_ROOT).
!!!
missing
* MUST: All filenames in rpm packages must be valid UTF-8.
OK
SHOULD Items:
* SHOULD: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD
query upstream to include it.
OK
* SHOULD: The description and summary sections in the package spec file should
contain translations for supported
Non-English languages, if available.
N/A
* SHOULD: The reviewer should test that the package builds in mock.
* SHOULD: The package should compile and build into binary rpms on all
supported architectures.
* SHOULD: The reviewer should test that the package functions as described. A
package should not segfault instead of running, for example.
* SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague,
and left up to the reviewers judgement to determine sanity.
OK
* SHOULD: Usually, subpackages other than devel should require the base package
using a fully versioned dependency.
N/A
* SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and
this is usually for development purposes,
so should be placed in a -devel pkg. A reasonable exception is that the
main pkg itself is a devel tool not
installed in a user runtime, e.g. gcc or gdb.
N/A
* SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring
the package which provides the file instead of the file itself.
N/A
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list