[Bug 503256] Review Request: gtkmm-utils - C++ utility and widget library based on glibmm and gtkmm

bugzilla at redhat.com bugzilla at redhat.com
Mon Jul 27 20:44:50 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503256





--- Comment #47 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-07-27 16:44:49 EDT ---
rpmlint output:
gtkmm-utils-example.x86_64: W: no-documentation
5 packages and 0 specfiles checked; 0 errors, 1 warnings.

This is OK.

**

The comment
 # Install compiled examples into %{_libdir}/%{name}
should be now
 # Install compiled examples into %{_bindir}

**

I suggest using
 %{_bindir}/gtkmm-utils-*
instead of
 %{_bindir}/*

**

The -doc package has no %files section. Move the %doc from -devel to the files
of -doc.

(Hmm, I was mistaken in comment #34; the documentation takes 1.2 MB, I must
have been looking at examples/ instead of doc/)

**

In addition to these submissions, you need to do a couple of informal package
reviews so that I can make sure you understand the packaging guidelines. Please
review only packages that are NOT tagged with FE-NEEDSPONSOR, as I will have to
do the formal reviews after you to check that you have got everything
correctly.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list