[Bug 226568] Merge Review: xmlto

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226568


Till Maas <opensource at till.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?,             |fedora-review+
                   |needinfo?(opensource at till.n |
                   |ame)                        |




--- Comment #18 from Till Maas <opensource at till.name>  2009-07-28 05:07:53 EDT ---
Sorry for the delay.

[OK] rpmlint output:
xmlto.i386: E: explicit-lib-dependency libxslt
- libxslt contains the binary xsltproc
xmlto-tex.i386: W: no-documentation
xmlto-xhtml.i386: W: no-documentation

[OK] Spec in %{name}.spec format

[OK] license allowed: GPLv2+
[OK] license matches shortname in License: tag
[OK] license in tarball and included in %doc: COPYING
[OK] package is code or permissive content:
{OK} patches sent to upstream and commented
[OK] Source0 is a working URL
{N/A} Sourceforge URL is Source0:
http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz
<OK> SourceX / PatchY prefixed with %{name}
[OK] Source0 matches Upstream:
12f297dc7051e4fef08339980f88a1dd  xmlto-0.0.22.tar.bz2

[OK] Package builds on all primary architectures:
http://koji.fedoraproject.org/koji/buildinfo?buildID=95375
[N/A] ExcludeArch bugs are filed and commented:
[OK] BuildRequires are complete (mock builds)
(OK) No file dependencies outside of /etc /bin /sbin /usr/bin /usr/sbin 

[N/A] %find_lang used for locales

[N/A] Every (sub)package containing libraries runs ldconfig
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
[N/A] .h (header) files are in -devel subpackage
[N/A] .a (static libraries) are in -static subpackage
[N/A] contains .pc (pkgconfig) files and has Requires: pkgconfig
(N/A) .pc files are in -devel subpackage
[N/A] contains .so.X(.Y) files and .so is in -devel
[N/A] -devel subpackage has Requires: %{name} = %{version}-%{release}
[N/A] .la files (libtool) are not included

[N/A] Has GUI and includes %{name}.desktop
[N/A] Follows desktop entry spec
[N/A] Valid .desktop Name
[N/A] Valid .desktop GenericName
[N/A] Valid .desktop Categories
[N/A] Valid .desktop StartupNotify
[N/A] .desktop file installed with desktop-file-install in %install
[N/A] Prefix: /usr not used (not relocatable)

[OK] Owns all created directories
[OK] no duplicates in %files
[OK] %defattr(-,root,root,-) is in every %files section
[OK] Does not own files or dirs from other packages
[OK] included filenames are in UTF-8

[OK] %clean is rm -rf %{buildroot} or $RPM_BUILD_ROOT 
[OK] %install starts with rm -rf %{buildroot} or $RPM_BUILD_ROOT 
[OK] Consistent macro usage

[N/A] large documentation is -doc subpackage
[OK] %doc does not affect runtime

{OK} no pre-built binaries (.a, .so*, executable)

{OK} well known BuildRoot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

{OK} PreReq not used
{OK} RPM_OPT_FLAGS honoured
{OK} Useful debuginfo generated
{OK} no duplication of system libraries
{OK} no rpath
{NOT OK} Timestamps preserved with cp and install
https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps

You can fix this with:
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"

{OK} Uses parallel make (%{?_smp_mflags})
{OK} Requires(pre,post) style notation not used
{OK} only writes to tmp /var/tmp $TMPDIR %{_tmppath} %{_builddir} (and
%{buildroot} on %install and %clean)
{OK} no Conflicts
{OK} nothing installed in /srv
{GOOD ENOUGH} Changelog in allowed format
https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs

For the 0.0.22-1 released the version-release was not added to the changelog
entry.


<GOOD ENOUGH> Architecture independent packages have: BuildArch: noarch
The tex and xhtml subpackage can nowadays be noarch:
https://fedoraproject.org/wiki/Features/NoarchSubpackages
But this is not enforced, so you do not need to make them noarch.

<OK> Sane Provides: and Requires:
{OK} Follows Naming Guidelines

Please add 'INSTALL="install -p"' to 'make install' to preserve timestamps and
consider to use noarch subpackages. The install issue is minor, therefore this
package is now APPROVED.

Also please consider removing the patches that are no longer used from the
devel branch:
xmlto-libpaper.patch
xmlto-stringparam.patch
xmlto-xhtml1.patch
xmlto-xmllintoptions.patch

(make unused-patches shows you these patches)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.