[Bug 493246] Review Request: Shutter -- a feature-rich screenshot program.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=493246





--- Comment #29 from Jan Klepek <jan.klepek at hp.com>  2009-07-29 14:59:55 EDT ---
Liang, 

why did you put -p switch off? I'm sorry if you got feeling that -p switch is
not mandatory.

The install script should look like:

install -d -m 0755 -p $RPM_BUILD_ROOT%{_bindir}
install -d -m 0755 -p $RPM_BUILD_ROOT%{_datadir}
cp -pfr bin/* $RPM_BUILD_ROOT%{_bindir}/
cp -pfr share/* $RPM_BUILD_ROOT%{_datadir}/

Please read what I have written above and try to understand what is difference
between what I have proposed and what do you have and which one meets packaging
guidelines.
see: https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps

Please with next version of specfile do a scratch build for F-11 and F-10 in
koji.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.