[Bug 512170] Review Request: pidgin-sipe - Pidgin plugin for connecting to MS Communications Server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=512170


David Woodhouse <dwmw2 at infradead.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dwmw2 at infradead.org




--- Comment #8 from David Woodhouse <dwmw2 at infradead.org>  2009-07-30 11:34:37 EDT ---
I blame the compiler. Three of these identical pieces of pointer arithmetic
lead to a successful compilation; the original version doesn't:

--- src/sip-sec-ntlm.c~ 2009-07-27 23:13:13.000000000 +0100
+++ src/sip-sec-ntlm.c 2009-07-30 16:32:29.000000000 +0100
@@ -502,7 +502,10 @@ purple_ntlm_gen_authenticate(guchar **nt

  /* Domain */
  tmsg->dom_off = sizeof(struct authenticate_message);
- tmp = ((char*) tmsg) + tmsg->dom_off;
+// tmp = ((char*) tmsg) + tmsg->dom_off;
+ tmp = ((char*) tmsg) + sizeof(struct authenticate_message);
+// tmp = (char *) (tmsg+1);
+// tmp = (char *)&tmsg[1];
  remlen = ((char *)tmsg)+msglen-tmp;
  tmsg->dom_len1 = tmsg->dom_len2 = (guint16)unicode_strconvcopy((gchar *)tmp,
domain, remlen);
  tmp += tmsg->dom_len1;

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.