[Bug 484511] Review Request: crunchyfrog - A multi-engine SQL client and database front-end

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484511


Rakesh Pandit <rpandit at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




--- Comment #10 from Rakesh Pandit <rpandit at redhat.com>  2009-06-24 04:11:40 EDT ---
http://ivazquez.fedorapeople.org/packages/crunchyfrog/crunchyfrog.spec
http://ivazquez.fedorapeople.org/packages/crunchyfrog/crunchyfrog-0.3.4-1.src.rpm 

I am reviewing ivazquez's files:

1. Why is %{dist} missing from srpm ? 

2. License snippet from code says "# the Free Software Foundation, either
version 3 of the License, or                                                    
# (at your option) any later version.     "

that means GPLv3+

3. may you check 
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
& http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files

for icon also you need hicolor-* dependency ..

may you check the spec file in #8

Thanks,

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.