[Bug 478930] Review Request: globus-rls-client - Globus Toolkit - Replica Location Service Client

bugzilla at redhat.com bugzilla at redhat.com
Mon Jun 1 04:48:17 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478930





--- Comment #4 from Mattias Ellert <mattias.ellert at fysast.uu.se>  2009-06-01 00:48:16 EDT ---
(In reply to comment #3)
> ! The file CHANGELOG can go to a %doc

The CHANGELOG file's last entry is for version 2.1.3, the current version is
5.1. Since the CHANGELOG file is not maintained it doesn't make much sense to
include it.

> * The source extraction guide is incomplete. The original source tree contains
> a ./java directory, which is missing from your tarball. Is there a reason?

Yes, the java directory is not part of the globus-rls-client source package,
but a separate source package of its own. The build GPT build instructions in
the pkgdata directory does not contain information about how to build the java
package. The java directory contains its own pkgdata directory with build
instructions for the java package. I have added a line to the source extraction
guide that removes the java directory before packaging the source tarball.

> ? There is some html documentation under the ./Doc directory. Currently there
> is a doxygen documentation in the doc package which seemed to me rather
> useless. Shall we replace it with the html documentation from the ./Doc
> directory?

The bug is in the LAC_DOXYGEN call in configure.in - it points to the main
directory instead of the library subdirectory. Fixed.

> * Please fix the compilation warnings of the type
>    rpc.c:395: warning: format '%d' expects type 'int', but argument 3 has type
> 'globus_size_t'  

Fixed.

http://www.grid.tsl.uu.se/repos/globus/info/new/globus-rls-client-5.1-2.fc10.src.rpm
http://www.grid.tsl.uu.se/repos/globus/info/new/globus-rls-client.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list